-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛Source Notion: added handing empty results in response #27073
🐛Source Notion: added handing empty results in response #27073
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
/test connector=connectors/source-notion
Build PassedTest summary info:
|
/test connector=connectors/source-notion
Build PassedTest summary info:
|
What
resolved: https://github.com/airbytehq/oncall/issues/2204
Sometimes notion returns response without results which leading TypeError: 'NoneType' object is not iterable.
How
Added response.json().get("results", []) to avoid type error while iterations.